feat: add KubernetesMetadata extensions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adohe
force-pushed
the
update_label_annotation
branch
from
5bf6c16 to
dbefd74
Compare
adohe
force-pushed
the
update_label_annotation
branch
from
dbefd74 to
fa0fe69
Compare
SparkYuan
reviewed
Apr 19, 2024
| Workload defines how to run your application code. Currently supported workload profile | ||
| includes Service and Job. | ||
| accessories: {str:any}, default is Undefined, optional. | ||
| Accessories defines a collection of accessories that will be attached to the workload. | ||
| labels: {str:str}, default is Undefined, optional. | ||
| extensions: [extv1.KubernetesMetadata], default is Undefined, optional. | ||
| Labels can be used to attach arbitrary metadata as key-value pairs to resources. |
There was a problem hiding this comment.
Please rename this description to extensions
SparkYuan
reviewed
Apr 19, 2024
| @@ -25,6 +24,9 @@ schema Job(WorkloadBase): | |||
| } | |||
| """ | |||
|
|
|||
| # The kind | |||
| kind: "job" = "job" | |||
There was a problem hiding this comment.
what does "job" = "job" mean? Would you like to create an enumeration for the kind variable with the default value of "job"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.